Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: package manager visual regressions #9504

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: package manager visual regressions #9504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/packageManager/src/components/LibraryList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ export const LibraryList: React.FC<ILibraryListProps> = (props) => {
selection={selection}
selectionMode={SelectionMode.single}
setKey="none"
onShouldVirtualize={() => false}
/>
</div>
</div>
Expand Down
8 changes: 7 additions & 1 deletion extensions/packageManager/src/components/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@ export const packageScrollContainerStyle = {
root: { borderTop: '1px solid #CCC', height: 'calc(100% - 150px)' },
};

export const tabAndSearchBarStyles = { root: { paddingLeft: '12px', paddingRight: '20px', height: '48px' } };
export const tabAndSearchBarStyles = {
root: {
paddingLeft: '12px',
paddingRight: '20px',
height: '48px',
},
};

export const ContentHeaderStyle = css`
padding: 5px 20px;
Expand Down
13 changes: 8 additions & 5 deletions extensions/packageManager/src/pages/Library.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,11 @@ const InstallButtonVersion = styled.span`
`;

const tabsStackStyle = css`
min-width: 512px;
overflow: auto;
overflow: hidden auto;
max-height: 100%;
flex: auto;
display: flex;
flex-flow: column nowrap;
`;

const fieldStyles = {
Expand Down Expand Up @@ -655,7 +658,7 @@ const Library: React.FC = () => {
/>
</Stack.Item>
)}
<Stack.Item align="stretch" styles={{ root: { flexGrow: 1, overflowX: 'hidden', maxHeight: '100%' } }}>
<Stack.Item align="stretch" css={tabsStackStyle}>
{!ejectedRuntime && (
<MessageBar
actions={
Expand All @@ -681,8 +684,8 @@ const Library: React.FC = () => {
<PivotItem headerText={strings.installHeader} itemKey={TABS.INSTALL} />
</Pivot>
</Stack.Item>
<Stack.Item align="end" grow={1}>
<Stack horizontal css={tabsStackStyle} horizontalAlign="center" tokens={{ childrenGap: 10 }}>
<Stack.Item align="center" grow={1}>
<Stack horizontal grow={1} horizontalAlign="end" tokens={{ childrenGap: 10 }} verticalAlign="center">
<Stack.Item>
<Dropdown
ariaLabel={formatMessage('Feeds')}
Expand Down