Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAS1.4.1] [Visual Requirements-Welcome] Underline or chevron is not provided for links present in the welcome tab screen #1712

Closed
awalia13 opened this issue Aug 9, 2019 · 7 comments

Comments

@awalia13
Copy link

awalia13 commented Aug 9, 2019

Actual Result:
Underline or chevron is not provided for links present in the welcome tab screen
Design guidelines, Download command Line tools, From azure, Locally links …etc

Expected Result:
Underline or chevron should be provided for links present in the welcome tab screen
Design guidelines, Download command Line tools, From azure, Locally links …etc

Note:
This issue exits for throughout application for all links wherever link present.

Same issue repro for below path
Navigate to the Open bot ->Select the Open bot control->Open bot dialog
1.Learn more
Welcome bot Framework emulator ->Navigate to the Sign in with Azure account -> Sign in with Azure account dialog
1.Dont have an azure account?signup
2.Learn more about registering services
Welcome Bot Framework Emulator ->Create new bot configuration
1.Learn more
Navigate to the Open bot ->Select the Open bot control->Open bot dialog ->Connect the bot
1.Learn more
Ngrok Settings
1.ngrok 2.wikipage 3.Privacy statement ..etc

The same issue is observed, on MacOs also.

Repro Steps.
1.Open the Bot Framework V4 Emulator.
2.Welcome tab screen gets opened
3. Navigate to the welcome tab screen links
4. Observe the issue

User Impact:
Users with low vision or color-blindness will find it difficult to identify these links.

Test Environment:
OS Build: Version 1903(OS Build 18362.239)
Browser: Edge
Application: Bot Framework V4 Emulator

OS: MacOs Version 10.15
Application: Bot Framework V4 Emulator (Version 4.5.2-80829 (4.5.2-80829.80829))

MAS Reference Link:
Sharepoint link
](url)
MAS1 4 1_Welcome
Underline or chevron is not provided for links- MacOs

@corinagum
Copy link
Contributor

I'm not sure that this is a MAS 1.4.1 issue. In this case, color is not the sole indication of focus - the lined box is an indicator just like underlining the text would also be a way of indication.

1.4.1 doesn't seem to address using a box focus instead of underline focus. If the box is not allowed, we will need to confirm with Design that we will be changing to something else, like underline.

@awalia13
Copy link
Author

Hi @corinagum - if we will fix as per below then we are good:

  1. The link text must have a 3:1 contrast ratio from the surrounding non-link text.
  2. Color of Focus Indicator should be 3:1.

@tonyanziano
Copy link
Contributor

@corinagum this should be fixed by #1783 according to the above criteria.

@Kumar2608
Copy link

Verified in latest Bot emulator version -4.5.2-79718 .Issue partially fixed .Hence we are reactivating this bug
Issue still repro'ing for "1.ngrok 2.wikipage 3.Privacy statement" links and check boxes
Please refer the attachment:1712.png
1712

@corinagum
Copy link
Contributor

I checked this in my PR #1877, and the focus is fixed to the darker blue. I'm assuming the page got fixed sometime inbetween PR #1783 and #1877

@Kumar2608
Copy link

Issue still repro'ing for check boxes hence we are reactivating this bug.
Please refer the attachments:1712.png
1712

@Kumar2608
Copy link

Issue got fixed hence we are closing this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants