Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1710, #1711, #1712] Fixed focus outline color issues. #1783

Merged
merged 1 commit into from
Aug 27, 2019
Merged

[#1710, #1711, #1712] Fixed focus outline color issues. #1783

merged 1 commit into from
Aug 27, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Aug 27, 2019 •
edited
Loading

#1710, #1711, #1712

===

Had to use a lighter blue for dark theme and a lighter blue for light theme because they were not passing the contrast ratio test even though it's what VS Code uses. However, the colors are both from the VS Code color palette.

Light
light_outline1

light_outline2

dark_outline3

Dark
dark_outline1

dark_outline2

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.518% when pulling 9f87cd0 on toanzian/acc-#1711 into 7997c47 on master.

@tonyanziano tonyanziano mentioned this pull request Aug 27, 2019
Closed
corinagum
corinagum approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyanziano tonyanziano changed the title Fixed focus outline color issues. [#1710, #1712] Fixed focus outline color issues. Aug 27, 2019
@tonyanziano tonyanziano merged commit 82dd1c6 into master Aug 27, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1711 branch August 27, 2019 23:30
@tonyanziano tonyanziano changed the title [#1710, #1712] Fixed focus outline color issues. [#1710, #1711, #1712] Fixed focus outline color issues. Sep 3, 2019
@tonyanziano tonyanziano mentioned this pull request Sep 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @corinagum