Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to export transcript messages from trace activities when in debug mode #1452

Merged
merged 5 commits into from
Apr 24, 2019

Conversation

justinwilaby
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 24, 2019

Coverage Status

Coverage increased (+0.02%) to 56.843% when pulling f4d1167 on jwilaby/export-trace-transcripts into 014fa59 on master.

@justinwilaby justinwilaby changed the title Added the ability to extract messages from trace activities when in debug mode Added the ability to export transcript messages from trace activities when in debug mode Apr 24, 2019
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a .bot file has been opened in Emulator mode, then switch modes to Sidecar mode and have a conversation via the external channel and subsequently save the transcript, the directory to save the transcript is incorrect. It defaults to what appears to be the activeBot's path. Please address this.

@justinwilaby justinwilaby force-pushed the jwilaby/export-trace-transcripts branch from ac69e32 to 2c4ca36 Compare April 24, 2019 17:38
tonyanziano
tonyanziano previously approved these changes Apr 24, 2019
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and Chris' concern seems to be fixed.

@justinwilaby justinwilaby dismissed cwhitten’s stale review April 24, 2019 20:05

Verbal communication - the issue raised has been solved

@justinwilaby justinwilaby merged commit 0d4f107 into master Apr 24, 2019
@justinwilaby justinwilaby deleted the jwilaby/export-trace-transcripts branch April 24, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants