V dai/clear state #1596
Merged
V dai/clear state #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanov-dan
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
| message: 'You have successfully cleared state.', | ||
| title: 'Success!', | ||
| }); | ||
| const { session } = require('electron'); |
There was a problem hiding this comment.
Although this is generally ok, we have established a pattern of placing requires at the top of the file using import. In this case it would be import * as electron from 'electron'; or import { session } from 'electron';
| title: 'Success!', | ||
| }); | ||
| const { session } = require('electron'); | ||
| await new Promise(resolve => session.defaultSession.clearStorageData({}, resolve)); |
There was a problem hiding this comment.
This should probably go in at line 299.
There was a problem hiding this comment.
Is there a technical reason the user is notified before the storage data is cleared?
There was a problem hiding this comment.
This is a scenario that @cwhitten requested.
justinwilaby
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.