Handle change to middleware #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
tdurnford and
tonyanziano
as code owners
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
tonyanziano
previously approved these changes
Aug 18, 2020
| @@ -203,6 +207,7 @@ export class Chat extends PureComponent<ChatProps, ChatState> { | |||
| return null; | |||
|
|
|||
| default: | |||
| debugger; | |||
There was a problem hiding this comment.
might want to remove this 😅
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
tonyanziano
pushed a commit
that referenced
this pull request
Aug 31, 2020
* Webchat Upgrade and Version number change Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Handle change to middleware (#2177) * Handle change to middleware * Updated babel preset env Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Reverted change to babel Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Locks updated to pre webchat change Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Post wechat check Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Prevent hoisting bf-chatdown Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated babel preset env Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: Webchat socket instantiation delay (#2179) * Updated websocket server code to backup messages if it is not connected * Refactored more occurances of socket send * Renaming variables * Added unit test to make sure backedup messages are cleared before connection starts * Lint fix * Updated release date Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * All tests working Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
webchatmiddleware 4.10.0 returns false forconversationUpdate, invokeevents. This PR makes sure it returns true before we render the resultsmicrosoft/BotFramework-WebChat@9e5f9e0#diff-5cc299788131ecb932a8b17abd1ba05bL6