Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support webchat middleware #2202

Merged
merged 4 commits into from
Nov 6, 2020
Merged

feat: support webchat middleware #2202

merged 4 commits into from
Nov 6, 2020

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Nov 6, 2020

  1. Support the new activity middleware contract provided by Webchat.
  2. core-js shims required by Webchat

Fixes #2201

Srinaath Ravichandran added 2 commits November 5, 2020 23:57
Support for updated middleware contracts
fff964d 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
typo fixed
ce51f7f 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath changed the base branch from main to v4.11.0 November 6, 2020 08:35
Srinaath Ravichandran added 2 commits November 6, 2020 00:45
Code cleanup
eed4196 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Let to const
75767ca 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
tonyanziano
tonyanziano approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srinaath srinaath merged commit 6bcfefd into v4.11.0 Nov 6, 2020
@srinaath srinaath deleted the feature/webchat-middleware branch November 6, 2020 18:10
@srinaath srinaath changed the title Feature/webchat middleware feat: support webchat middleware Nov 6, 2020
@tonyanziano tonyanziano mentioned this pull request Nov 9, 2020
Closed
tonyanziano pushed a commit that referenced this pull request Nov 9, 2020
@srinaath
V4.11.0 to main (#2204)
343c26d 
* Changelog and webchat package version update

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Feature/webchat middleware (#2202)

* Changelog updated

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Typo in changelog

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
@waynehsmith waynehsmith mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the new middleware contract for Webchat
2 participants
@srinaath @tonyanziano