Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on microphone after blocking microphone will throw JavaScript error - related to #3666 #2619

Closed
3 tasks
compulim opened this issue Nov 20, 2019 · 3 comments
Closed
3 tasks

Clicking on microphone after blocking microphone will throw JavaScript error - related to #3666 #2619

compulim opened this issue Nov 20, 2019 · 3 comments
Labels
area-speech backlog Out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. Duplicate This issue or pull request already exists front-burner needs-scheduling p1 Painful if we don't fix, won't block releasing
Milestone
R12

Comments

@compulim
Copy link
Contributor

Screenshots

image

Version

4.6.0

Describe the bug

After the microphone access is blocked in the browser (Chrome), clicking on the microphone button again will throw JavaScript error saying "Speech recognition is not supported".

Few things to do:

  • Investigates why it is causing an uncaught exception (i.e. clearing out the screen)
  • After the first block, investigates if we could disable microphone button for the session (turn it into envelope button)
  • Also, investigates why the uncaught exception cannot be contained within the connectivity status

To Reproduce

  1. Open Chrome in incognito mode.
  2. Load Web Chat 4.6.
  3. Click on microphone button.
  4. When the browser asked for microphone access, click "Deny".
  5. Click the microphone button again.

Expected behavior

There are two expected behaviors, either one will work:

  1. After step 4, Web Chat switch off the microphone button by turning it into an envelope button.
  2. After step 5, Web Chat do nothing.

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. labels Nov 20, 2019
@compulim compulim mentioned this issue Nov 20, 2019
Closed
@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. Pending customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Nov 20, 2019
@corinagum corinagum added the needs-repro Waiting for repro or investigation label Dec 3, 2019
@cwhitten cwhitten added p1 Painful if we don't fix, won't block releasing R8 and removed needs-repro Waiting for repro or investigation backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Jan 2, 2020
@cwhitten cwhitten removed the R8 label Jan 9, 2020
@corinagum corinagum added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Jan 9, 2020
@Bradrajkumar
Copy link

Bradrajkumar commented Feb 13, 2020 •
edited
Loading

hi Team,

still onclick on block button in popup and again clicking on mic button is vanishing the webchat.
here is the screnshot.
Screenshot (18)
Screenshot (19)

@corinagum corinagum added front-burner and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Sep 23, 2020
@compulim compulim added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Oct 5, 2020
@corinagum corinagum added this to the R12 milestone Dec 21, 2020
@corinagum
Copy link
Contributor

possibly fixed by #3666

@corinagum corinagum changed the title Clicking on microphone after blocking microphone will throw JavaScript error Clicking on microphone after blocking microphone will throw JavaScript error - related to #3666 Jan 20, 2021
@cwhitten
Copy link
Member

closing as a dupe of #3411

@corinagum corinagum added the Duplicate This issue or pull request already exists label Jan 21, 2021
@microsoft microsoft locked and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-speech backlog Out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. Duplicate This issue or pull request already exists front-burner needs-scheduling p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
R12
Development

No branches or pull requests
4 participants
@cwhitten @compulim @corinagum @Bradrajkumar