Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directline speech stops working if user clicks on the Mic during recognition #3411

Closed
collegewap opened this issue Aug 13, 2020 · 11 comments · Fixed by #3694
Closed

Directline speech stops working if user clicks on the Mic during recognition #3411

collegewap opened this issue Aug 13, 2020 · 11 comments · Fixed by #3694
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report external-cognitive-services p1 Painful if we don't fix, won't block releasing
Milestone

Comments

@collegewap
Copy link

Screenshots

image

Version

4.9.2

Describe the bug

Steps to reproduce

  1. Go to https://compulim.github.io/webchat-loader/
  2. Select "MockBot (Direct Line Speech)"
  3. Click on "Open Web Chat in a new window"
  4. Speak something
  5. Before the bot responds, click on Mic again
  6. The screen would be hung showing "Starting.."

The issue is replicable in some other scenarios as well. I am unable to mention the exact steps. If you play around the mic button, it gets hung.

Expected behavior

Webchat should not get hung.

[Bug]

@collegewap collegewap added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Aug 13, 2020
@collegewap collegewap changed the title Directline speech get hung if user clicks on the Mic when the recognition is occuring Directline speech gets hung if user clicks on the Mic when the recognition is occurring Aug 13, 2020
@carlosscastro carlosscastro added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Aug 13, 2020
@carlosscastro
Copy link
Member

Thanks for reporting. We'll investigate and prioritize during our planning and update as necessary. Thanks!

@carlosscastro
Copy link
Member

@compulim if possible please add to the R11 investigate backlog.

@collegewap
Copy link
Author

Happens in mock bot also.

Steps to replicate:

  1. Open 3a
  2. Say hello
  3. After bot speaks, click on Mic and don't say anything
  4. Now I get the second message
  5. After the bot finishes speaking, click on Mic.
  6. It will get hung on "Starting..."

This happens more often in my custom bot

image

@peterinnesmsft
Copy link
Contributor

@compulim is there any update on this one? Outside of SLA, so if we could prioritize a response, that would be great.

@compulim compulim added this to the R11 milestone Aug 19, 2020
@peterinnesmsft
Copy link
Contributor

@collegewap we will investigate and handle this issue as part of our next upcoming release cycle.

@peterinnesmsft peterinnesmsft added the customer-replied-to Required for internal reporting. Do not delete. label Aug 20, 2020
@compulim
Copy link
Contributor

Sorry for late response. I am starting to investigate and will post my investigation notes here.

@compulim
Copy link
Contributor

compulim commented Aug 21, 2020

Minimal repro

  • Connect using DLSpeech to any bots
  • After connected, click on microphone button and remain silent
    • This should trigger InitialSilenceTimeout event on the service side
  • The bot will say "Unknown command: ''. Type help to learn more."
  • Click on microphone button again
  • Expected: the microphone can be turned on again
  • Actual: it just say "Starting..." and hung there

Investigation

1

It seems Speech SDK has an issue after InitialSilenceTimeout event.

In the second click, we called DialogServiceConnector.listenOnceAsync. But the function return immediately because the check isTurnComplete is false. It seems Speech SDK did not stop completely after InitialSilenceTimeout.

image

2

After bumped to microsoft-cognitiveservices-speech-sdk@1.13.1 (in PR #3432), I am still seeing the problem of InitialSilenceTimeout not able to reset the isTurnComplete flag to true.

Will investigate more on this code path.

3

This is related to microsoft/cognitive-services-speech-sdk-js#211.

We need to wait for the Cognitive Services Speech team to fix the issue in their SDK > 1.13.1.

Next steps

@compulim compulim added blocked currently prevented from making progress external-cognitive-services and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Aug 21, 2020
@cwhitten cwhitten added the p1 Painful if we don't fix, won't block releasing label Oct 14, 2020
@cwhitten cwhitten modified the milestones: R11, R12 Oct 14, 2020
@cwhitten
Copy link
Member

Moving from R11 with the understanding that we won't have enough lead time to integrate a drop of the speech sdk

@chrimc62 chrimc62 added the ExemptFromDailyDRIReport exempt from daily DRI report label Oct 28, 2020
@corinagum corinagum changed the title Directline speech gets hung if user clicks on the Mic when the recognition is occurring Directline speech stops working if user clicks on the Mic during recognition Nov 2, 2020
@edwgj
Copy link

edwgj commented Nov 22, 2020

Hi, another bug is reproduced here:

  1. Go to https://compulim.github.io/webchat-loader/
  2. Select "MockBot (Direct Line Speech)"
  3. Click on "Open Web Chat in a new window"
  4. Type help
  5. The bot sends cards with lots of options, click on mic
  6. While the bot is listening, click on any card option
  7. Web chat UI disappear, the screen gets blank

@corinagum
Copy link
Contributor

corinagum commented Jan 13, 2021

This is related to #3575. Keeping this issue open to ensure we verify fixed behavior post-bump.

I removed the blocked label since the new sdk version is available now.

@compulim
Copy link
Contributor

compulim commented Feb 1, 2021

This seems fixed in Speech SDK 1.15.0.

However, while operating in DLSpeech mode, Speech SDK does not support abort. That means, all speech sending to the bot cannot be stopped even the microphone button is clicked (it's in disabled state anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report external-cognitive-services p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants