Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listenOnce only works one time #211

Closed
encorona-ms opened this issue Jul 16, 2020 · 6 comments
Closed

listenOnce only works one time #211

encorona-ms opened this issue Jul 16, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@encorona-ms
Copy link

encorona-ms commented Jul 16, 2020

Consider the following scenario

  1. Start a connection
  2. listen for audio
  3. Custom Commands responds and listens again using listenOnce
  4. the user never responds so after 5 seconds the sdk stops listening
  5. when we try to listen for audio again (i.e. click the mic button again) with listenOnce it doesn't work anymore
@rhurey rhurey added the bug Something isn't working label Jul 20, 2020
@rhurey
Copy link
Member

rhurey commented Jul 20, 2020

Thanks for getting in touch with us.

Looking at the behavior when there's only silence sent to the service for listenOnceAsync, it looks like the correct events aren't being raised.

I've opened a workitem in our internal tracking system and will follow up tomorrow once I know if the engineers who own the dialog connector are in agreement.

@rhurey
Copy link
Member

rhurey commented Jul 22, 2020

We've got an internal bug tracking this, and will update this issue when it's fixed.

@compulim
Copy link
Contributor

compulim commented Aug 21, 2020

@rhurey we are also seeing similar issue in 1.13.1. After line 144 is executed and returned with InitialSilenceTimeout, none of the breakpoints were hit. Thus, isTurnComplete is never set to true again.

image

@trrwilson trrwilson added the in review Acknowledged and being looked at now label Sep 10, 2020
@collegewap
Copy link

Any update on this?

@brandom-msft
Copy link
Member

A fix addressing this has been merged and will also be available in the next release.
#244

@brandom-msft
Copy link
Member

@compulim for awareness on the related, blocking issue for WebChat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants