Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-hidden is expecting boolean, but passed as string #2639

Closed
compulim opened this issue Nov 26, 2019 · 1 comment · Fixed by #2640
Closed

aria-hidden is expecting boolean, but passed as string #2639

compulim opened this issue Nov 26, 2019 · 1 comment · Fixed by #2640
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Nov 26, 2019 •
edited
Loading

Screenshots

image

Version

master

Describe the bug

In CarouselFilmStrip.js line 134, it is passing string "true" to <Bubble>.

image

But in Bubble.js, it is expecting boolean.

image

This is causing a React warning in console.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'playground
  2. Type layout carousel
  3. Open console log and check for warnings

Expected behavior

No warnings.

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Nov 26, 2019
@corinagum
Copy link
Contributor

🤦🏻‍♀️

corinagum added a commit to corinagum/BotFramework-WebChat that referenced this issue Nov 26, 2019
@corinagum
Fix microsoft#2639, proptypes issue
26f086a
@corinagum corinagum mentioned this issue Nov 26, 2019
Merged
1 task
corinagum added a commit that referenced this issue Nov 26, 2019
@corinagum
Fix #2639, proptypes issue (#2640)
6cf7d1d 
* Fix #2639, proptypes issue

* Update CHANGELOG.md

* Fix CHANGELOG.md
@corinagum corinagum added R7 and removed Pending labels Nov 26, 2019
@compulim compulim mentioned this issue Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this issue Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2639, proptypes issue corinagum/BotFramework-WebChat
2 participants
@compulim @corinagum