Adaptive Cards TextBlock heading should start at level 2 #4747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
TextBlock
heading elements should start at level 2, by @compulim, in PR #4747Description
Adding a new
axe-core
to verify there are no heading elements of level 1.Design
Heading 1 is reserved for page-level heading. Web Chat is a component and should not use heading of level 1.
Specific Changes
textBlock.headingLevel
set to2
axe-core
check to make sure we have no<h1>
or<anything role="heading" aria-level="1">
<h1>
in all testspage-has-heading-one
CHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)