-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese translation is available in the strings file, but it is missing from the mapping #764
Comments
I believe it is covered by the final case, because The reason this mapping code exists is because most, but not all, locales with multiple dialects can share a single string table. In the case of Japan, I guess, there are no multiple dialects. |
Yes, we have a case where it is not working, even if we pass ja (will verify more and send you more info). but what if you pass ja-jp? why is this one treated differently? |
Here I was just following the lead of the translator. If it's not right let's fix it. |
I think the fix is to follow the pattern that's established. |
microsoft#764 making ja-jp consistent with other langs
#764 making ja-jp consistent with other langs
Sorry about this - I should have double checked before merging this change. |
microsoft#764 making ja-jp consistent with other langs
* #764 making ja-jp consistent with other langs #764 making ja-jp consistent with other langs * Adding temp CardImage attachment and test. * Commiting new changes. * Rendering tap selectaction. * Adding image tap tests. * Implementing card tap tests * Implementing card action call test. * Cleaning files for PR. * Cleaning code. * Improving evaluate function code.
the mapping at the bottom of the strings file is missing ja
export const strings = (locale: string) => {
if (locale.startsWith('da'))
locale = 'da-dk';
else if (locale.startsWith('de'))
locale = 'de-de';
else if (locale.startsWith('no') || locale.startsWith('nb') || locale.startsWith('nn'))
locale = 'nb-no';
else if (locale.startsWith('pl'))
locale = 'pl-pl';
else if (locale.startsWith('ru'))
locale = 'ru-ru';
else if (locale.startsWith('nl'))
locale = 'nl-nl';
else if (locale.startsWith('lv'))
locale = 'lv-lv';
else if (locale.startsWith('pt'))
locale = 'pt-br';
else if (locale.startsWith('fr'))
locale = 'fr-fr';
else if (locale.startsWith('es'))
locale = 'es-es';
else if (locale.startsWith('el'))
locale = 'el-gr';
else if (locale.startsWith('it'))
locale = 'it-it';
else if (locale === 'zh-hant' || locale === 'zh-hk' || locale === 'zh-mo' || locale === 'zh-tw')
locale = 'zh-hant';
else if (locale.startsWith('zh'))
locale = 'zh-hans';
else if (locale.startsWith('cs'))
locale = 'cs-cz';
else if (locale in localizedStrings === false)
locale = 'en-us';
The text was updated successfully, but these errors were encountered: