Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump botframework-directlinejs in all packages/samples #1538

Closed
wants to merge 1 commit into from

Conversation

cwhitten
Copy link
Member

No description provided.

@cwhitten cwhitten requested a review from compulim December 22, 2018 01:43
@compulim
Copy link
Contributor

compulim commented Dec 22, 2018

Looks like it is missing package-lock.json, causing errors in npm ci in Travis CI.

If you have package-lock.json, please submit along. Otherwise, please do not modify package.json manually, always use either lerna add or npm install for dependency management. And also make sure npm is of latest version so it emit latest format of package-lock.json.

@cwhitten
Copy link
Member Author

cwhitten commented Dec 22, 2018

Ah, yeah this isn't ready. The lockfile generation on Mac looks to be doing something different than lockfile generation on Windows and I was inspecting the diff a bit before pushing them up.

This is what is happening: https://npm.community/t/package-lock-json-changes-from-one-npm-install-to-the-next/1454

It looks like a fix has been merged into the npm cli project but a version hasn't been cut yet: npm/cli#76

My environment is on node v10.14.1 npm 6.4.1. I may downgrade npm to 6.0.x and see if the behavior is still occurring.

@compulim
Copy link
Contributor

Yea, it upset a lot of people when the fix is not in 6.4.1, including me.

As long as we are adding more optional than removing them, I am fine with it. And AFAIK, npm ci is fine with the missing optional too.

@cwhitten
Copy link
Member Author

closing in lieu of #1544

@cwhitten cwhitten closed this Dec 26, 2018
@cwhitten cwhitten deleted the bump-directline branch December 26, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants