Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: Incoming activity to JavaScript event #1567

Merged
merged 7 commits into from
Jan 12, 2019
Merged

Sample: Incoming activity to JavaScript event #1567

merged 7 commits into from
Jan 12, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jan 10, 2019 •
edited
Loading

Fix #1516

In console log, this sample will dump the activity.

image

Changelog

@compulim compulim added the Sample Implement PoC or sample code label Jan 10, 2019
@coveralls
Copy link

coveralls commented Jan 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 741

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.939%
Totals Coverage Status
Change from base Build 740: 0.0%
Covered Lines: 730
Relevant Lines: 1450
💛 - Coveralls

corinagum
corinagum approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky things

README.md Outdated Show resolved Hide resolved
samples/15.b.incoming-activity-event/README.md Outdated Show resolved Hide resolved
samples/15.b.incoming-activity-event/README.md Show resolved Hide resolved
samples/15.b.incoming-activity-event/README.md Outdated Show resolved Hide resolved
samples/15.b.incoming-activity-event/index.html Outdated Show resolved Hide resolved
@compulim compulim merged commit a10e0e8 into microsoft:master Jan 12, 2019
@compulim compulim deleted the sample-javascript-event branch January 12, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

Assignees
No one assigned
Labels
Sample Implement PoC or sample code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compulim @coveralls @corinagum