Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass conversationId to DirectLineJS constructor #1614

Merged
merged 3 commits into from Jan 22, 2019
Merged

Pass conversationId to DirectLineJS constructor #1614

merged 3 commits into from Jan 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2019

Added conversationId as an argument while instantiating DirectLine. Doing this will resume the conversation history related to a particular conversationId

@neetudas24
Fixed issue #1613
603c28d 
Added conversationId as an argument while instantiating DirectLine. Doing this will resume the conversation history related to a particular conversationId
@coveralls
Copy link

coveralls commented Jan 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 803

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 47.754%
Totals Coverage Status
Change from base Build 796: 0.4%
Covered Lines: 793
Relevant Lines: 1496
💛 - Coveralls

corinagum
corinagum previously requested changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments and add your fix to the CHANGELOG.md. Thank you for the PR!

packages/bundle/src/createDirectLine.js Outdated Show resolved Hide resolved
@compulim compulim changed the title Fixed issue #1613 Pass conversationId to DirectLineJS constructor Jan 18, 2019
@msftclas
Copy link

msftclas commented Jan 19, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@a-b-r-o-w-n a-b-r-o-w-n dismissed corinagum’s stale review January 22, 2019 17:37

feedback was addressed

a-b-r-o-w-n
a-b-r-o-w-n approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@a-b-r-o-w-n a-b-r-o-w-n merged commit beabb41 into microsoft:master Jan 22, 2019
@corinagum corinagum mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coveralls @msftclas @a-b-r-o-w-n @corinagum @neetudas24