Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intl fallback #1696

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Add Intl fallback #1696

merged 2 commits into from
Feb 5, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 5, 2019 •
edited
Loading

Fix #1533.

Changelog

Added

  • component: Add fallback logic to browser which do not support window.Intl, by @compulim, in PR #1696

@coveralls
Copy link

Pull Request Test Coverage Report for Build 949

  • 0 of 13 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 53.155%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Localization/en-US.js 0 2 0.0%
packages/component/src/Localization/fr-FR.js 0 2 0.0%
packages/component/src/Localization/ja-JP.js 0 2 0.0%
packages/component/src/Localization/zh-HANS.js 0 2 0.0%
packages/component/src/Localization/zh-YUE.js 0 2 0.0%
packages/component/src/Localization/zh-HANT.js 0 3 0.0%
Totals Coverage Status
Change from base Build 942: -0.5%
Covered Lines: 914
Relevant Lines: 1564
💛 - Coveralls

@compulim compulim merged commit 9e3c27a into microsoft:master Feb 5, 2019
@compulim compulim deleted the feat-intl-fallback branch February 5, 2019 18:53
@compulim compulim restored the feat-intl-fallback branch February 5, 2019 18:53
@compulim compulim deleted the feat-intl-fallback branch February 5, 2019 18:53
@InformComms InformComms mentioned this pull request Feb 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compulim @coveralls @a-b-r-o-w-n @corinagum