Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-scroll-to-bottom@1.3.1 #1725

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Bump react-scroll-to-bottom@1.3.1 #1725

merged 1 commit into from
Feb 13, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 13, 2019 •
edited
Loading

Fix #1697.

Bumping react-scroll-to-bottom to 1.3.1, which will fix #1697. Related changes:

  • #10, fix scroll animation may not ending properly
  • #13, fix occasional scroll lock issue in Firefox and Chrome
  • #15, fix scroll to bottom button show up on some Hi-DPI settings

Changelog

Changed

@compulim compulim added 4.0 and removed 4.0 labels Feb 13, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 56.692% when pulling 662cffa on compulim:bump-react-scroll-to-bottom into f4699be on Microsoft:master.

@compulim compulim merged commit a4a9577 into microsoft:master Feb 13, 2019
@compulim compulim deleted the bump-react-scroll-to-bottom branch February 13, 2019 23:56
@compulim
Copy link
Contributor Author

Forgot CHANGELOG.md, will update it.

@compulim compulim mentioned this pull request Feb 14, 2019
Closed
@compulim compulim mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll Issue on Firefox
3 participants
@compulim @coveralls @corinagum