Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'cursor: pointer' on button instances #1819

Merged
merged 3 commits into from
Mar 20, 2019
Merged

Remove 'cursor: pointer' on button instances #1819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd23643
Remove cursor: pointer on button instances
Mar 19, 2019
a09b9d6
Update CHANGELOG.md
Mar 19, 2019
9a2ec26
PR Fixes
Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed
- Fix [#1423](https://github.com/Microsoft/BotFramework-WebChat/issues/1423). Added sample for hosting WebChat in Angular, by [@omarsourour](https://github.com/omarsourour) in PR [#1813](https://github.com/Microsoft/BotFramework-WebChat/pull/1813)
- Fix [#1767](https://github.com/Microsoft/BotFramework-WebChat/issues/1767). Remove `cursor: pointer` from buttons, by [@corinagum](https://github.com/corinagum) in PR [#1819](https://github.com/Microsoft/BotFramework-WebChat/pull/1819)

## [4.3.0] - 2019-03-04

Expand Down
1 change: 0 additions & 1 deletion packages/component/src/Styles/StyleSet/ScrollToEndButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export default function ({
borderWidth: 0,
bottom: 5,
color: transcriptOverlayButtonColor,
cursor: 'pointer',
outline: 0,
padding: paddingRegular,
position: 'absolute',
Expand Down
2 changes: 0 additions & 2 deletions packages/component/src/Styles/StyleSet/SendBoxButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ export default function ({
width: sendBoxHeight,

'&:not(:disabled)': {
cursor: 'pointer',

'&:focus svg': {
fill: sendBoxButtonColorOnFocus
},
Expand Down
3 changes: 1 addition & 2 deletions packages/component/src/Styles/StyleSet/SuggestedAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ export default function createSuggestedActionStyle({
'&:not(:disabled)': {
background: suggestedActionBackground,
border: suggestedActionBorder,
color: suggestedActionTextColor,
cursor: 'pointer'
color: suggestedActionTextColor
}
}
};
Expand Down
1 change: 0 additions & 1 deletion packages/playground/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const ROOT_CSS = css({
'& > button': {
backgroundColor: 'rgba(128, 128, 128, .2)',
border: 0,
cursor: 'pointer',
outline: 0,
marginBottom: 10,
padding: '5px 10px',
Expand Down
1 change: 0 additions & 1 deletion packages/playground/src/JSONDebugView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const ROOT_CSS = css({
'& > button.debug': {
backgroundColor: 'Transparent',
border: 0,
cursor: 'pointer',
outline: 0,
padding: 10,
position: 'absolute',
Expand Down
1 change: 0 additions & 1 deletion packages/playground/src/createDevModeActivityMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const ROOT_CSS = css({
'& > button': {
backgroundColor: 'transparent',
border: 0,
cursor: 'pointer',
margin: 0,
outline: 0,
padding: 0,
Expand Down
1 change: 0 additions & 1 deletion samples/07.a.customization-timestamp-grouping/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#buttonBar > a {
border: solid 2px #0063B1;
color: #0063B1;
cursor: pointer;
font-family: Calibri, 'Helvetica Neue', Arial, sans-serif;
font-size: 80%;
margin: 0 10px 10px 0;
Expand Down
2 changes: 0 additions & 2 deletions samples/09.customization-reaction-buttons/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ Next, add styling via glamor and the classes that will be applied in this compon
+ '& > li > button': {
+ background: 'White',
+ border: 'solid 1px #E6E6E6',
+ cursor: 'pointer',
+ marginBottom: 2,
+ padding: '2px 5px 5px'
+ }
Expand Down Expand Up @@ -179,7 +178,6 @@ Make sure `activityMiddleware` is passed into the the Web Chat component, and th
+ '& > li > button': {
+ background: 'White',
+ border: 'solid 1px #E6E6E6',
+ cursor: 'pointer',
+ marginBottom: 2,
+ padding: '2px 5px 5px'
+ }
Expand Down
1 change: 0 additions & 1 deletion samples/09.customization-reaction-buttons/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
'& > li > button': {
background: 'White',
border: 'solid 1px #E6E6E6',
cursor: 'pointer',
marginBottom: 2,
padding: '2px 5px 5px'
}
Expand Down
2 changes: 0 additions & 2 deletions samples/12.customization-minimizable-web-chat/src/MinimizableWebChat.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
bottom: 20px;
box-shadow: 0 0 20px rgba(0, 0, 0, .2);
color: White;
cursor: pointer;
font-size: 30px;
height: 64px;
outline: 0;
Expand Down Expand Up @@ -74,7 +73,6 @@
background-color: Transparent;
border: 0;
color: White;
cursor: pointer;
outline: 0;
}

Expand Down
1 change: 0 additions & 1 deletion samples/13.customization-speech-ui/src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
background-color: transparent;
border: solid 2px #61DAFB;
border-radius: 50%;
cursor: pointer;
margin: 0;
outline: 0;
padding: 3vmin;
Expand Down
1 change: 0 additions & 1 deletion samples/16.customization-selectable-activity/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ body { margin: 0 }
}

.activity-wrapper {
cursor: pointer;
margin: 5px;
padding: 5px;
}
Expand Down
1 change: 0 additions & 1 deletion samples/17.chat-send-history/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ body { margin: 0 }
}

.activity-wrapper {
cursor: pointer;
margin: 5px;
padding: 5px;
}
Expand Down