Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input hint consecutive tests #2299

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Add input hint consecutive tests #2299

merged 2 commits into from
Aug 13, 2019

Conversation

compulim
Copy link
Contributor

Fix #2158.

This will add tests for input hint on consecutive activities, based on the table below.

1st activity 2nd activity Should turn on microphone if via microphone
Accepting input Accepting input No
Accepting input Expecting input Yes
Accepting input Ignoring input No
Expecting input Accepting input Yes
Expecting input Expecting input Yes
Expecting input Ignoring input No (explicitly turn it off)
Ignoring input Accepting input No
Ignoring input Expecting input Yes
Ignoring input Ignoring input No

@coveralls
Copy link

coveralls commented Aug 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 66.152% when pulling 68c7e7c on compulim:fix-2158 into 5f745a6 on microsoft:master.

corinagum
corinagum approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit a25abd0 into microsoft:master Aug 13, 2019
@compulim compulim deleted the fix-2158 branch August 13, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write more tests for post-4.5 release
3 participants
@compulim @coveralls @corinagum