Add ES5 polyfills and dev server to embed page #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten and
tonyanziano
as code owners
corinagum
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
embed: Added ES5 polyfills and dev server, by @compulim, in PR #2315Description
Today, embed page is not supported under IE11 due to missing of ES5 polyfills.
We are adding ES5 polyfills to the embed page so it will run smoothly under IE11.
We are also adding dev server to host the embed page locally, without using Fiddler.
Specific Changes
core-js,url-search-params-polyfill, andwhatwg-fetchto the embed pagerestifyet al. for the dev server