Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saga error should not result in unhandled exception #2421

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix saga error should not result in unhandled exception #2421

merged 1 commit into from
Oct 29, 2019

Conversation

compulim
Copy link
Contributor

Fixes #2420

Changelog Entry

Fixed

  • Fix #2420. Fix saga error should not result in an unhandled exception, by @compulim in PR #2421

Description

Saga error is currently resulted in unhandled exception. Once that is fixed, it become disconnected, instead of keeping at saga error.

Specific Changes

  • Modified connectivityStatus.js
    • Fixed null reference exception
    • Should not change connectivity status once it become sagaerror
  • Testing Added
    • We currently do not have tests to check how many console errors

tdurnford
tdurnford approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

corinagum
corinagum suggested changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://webchattest.blob.core.windows.net/travis-result/2019/09/22/71xj9/__image_snapshots__/chrome-docker/__diff_output__/offline-ui-js-offline-ui-should-display-network-interruption-occurred-reconnecting-status-when-connection-is-interrupted-1-diff.png

Test is failing

@compulim
Copy link
Contributor Author

https://webchattest.blob.core.windows.net/travis-result/2019/09/22/71xj9/__image_snapshots__/chrome-docker/__diff_output__/offline-ui-js-offline-ui-should-display-network-interruption-occurred-reconnecting-status-when-connection-is-interrupted-1-diff.png

Test is failing

Yap, was working on this yesterday. It works on my PC. 🤔

@compulim compulim force-pushed the fix-2420 branch 2 times, most recently from 66e1659 to 0271367 Compare September 25, 2019 07:08
@coveralls
Copy link

coveralls commented Sep 25, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 65.336% when pulling 5e6f7d2 on compulim:fix-2420 into fab7cd8 on microsoft:master.

@corinagum
Copy link
Contributor

Ping

@corinagum
Copy link
Contributor

ping...

1 similar comment
@tdurnford
Copy link
Contributor

ping...

@compulim compulim merged commit 028e36a into microsoft:master Oct 29, 2019
@compulim compulim deleted the fix-2420 branch October 29, 2019 02:45
@compulim compulim mentioned this pull request Oct 29, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When saga error occurred, it should not turn into disconnect
4 participants
@compulim @coveralls @corinagum @tdurnford