Should interrupt speech synthesis after microphone button is clicked #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
corinagum
suggested changes
Sep 27, 2019
samples/06.h.cognitive-services-speech-recognition-only/index.html
Outdated
Show resolved
Hide resolved
samples/06.h.cognitive-services-speech-recognition-only/index.html
Outdated
Show resolved
Hide resolved
samples/06.h.cognitive-services-speech-recognition-only/index.html
Outdated
Show resolved
Hide resolved
samples/06.h.cognitive-services-speech-recognition-only/index.html
Outdated
Show resolved
Hide resolved
samples/06.h.cognitive-services-speech-recognition-only/index.html
Outdated
Show resolved
Hide resolved
samples/06.e.cognitive-services-speech-services-with-lexical-result/index.html
Outdated
Show resolved
Hide resolved
corinagum
suggested changes
Sep 30, 2019
samples/06.h.cognitive-services-speech-recognition-only/README.md
Outdated
Show resolved
Hide resolved
samples/06.h.cognitive-services-speech-recognition-only/index.html
Outdated
Show resolved
Hide resolved
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
…html Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
corinagum
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Will add new tests)
Changelog Entry
Fixed
Description
Today, the microphone button does not stop synthesizing. And since synthesizing is still ongoing, microphone will not turn on to prevent echo.
Tomorrow, the microphone button will stop synthesizing. And this should immediately turn on the microphone.
Specific Changes