Stop dictate if microphone is not available #2517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2516.
Changelog Entry
expecting
input hint on Safari, by @compulim in PR #2517Description
Safari block microphone access if the code was not executed based on an user interaction.
We can check if we have access to microphone (see #2516). But the microphone check will result in an non-user interaction code, thus, code executed after the check will be blocked for microphone access.
In this PR, we are turning on microphone and checking access at the same time. If access is not granted, we will turn off microphone.
Specific Changes
Dictation.js
Testing Added