-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1835 to verical stacking for SuggestedActions #2596
Conversation
@compulim could you review? Thanks :) |
@spyip could you look at merge conflicts? Sorry :( |
@spyip, one more thing, could you run |
Is this change already in production? window.WebChat.renderWebChat({ Could you please suggest why this is not working? |
@anishjaindev the change is not in production yet. We are planning to ship the next release before mid-December. If you want to try out the fix with a development build, you can build |
can you just provide a screenshot what it will look like? like most people I suppose, we would like to have the buttons only using new lines when there is not enough space on the old line. Will stacked do that behaviour, or will it act differently? See this image for what I would like to have as a behaviour, and in my opinion clearly is the most user-friendly: |
Please see the test images in the PR. Your example is horizontal with line breaks - the changes that @spyip has incorporated provide a vertical stacking for the suggested actions. |
That sounds very promising to me. Can you tell me, how to do your mentioned "horizontal with linebreaks"? Thanks a lot. |
Yea, if "horizontal with line breaks" is achievable, could you please suggest what is the hack for that? It does look to be good alternative. |
horizontal with line breaks is not currently supported on Web Chat. Since there are already two of you looking for this feature, I recommend filing a feature request on our repo and continuing discussion there. :) |
I could do small hack for showing suggestion options in "horizontal with line breaks" using the below css workaround. But would like to have some standard approach to achieve the same. .css-nil > div > * > ul { .css-nil > div > * > ul > li { |
Fixes #1835 to verical stacking for SuggestedActions
Changelog Entry
Added
suggestedActionLayout
todefaultStyleOptions
, by @spyip, in PR #2596Description
Added 'stacked' layout to suggested-actions
Specific Changes