Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smart Display sample #2649

Merged
merged 35 commits into from
Dec 10, 2019
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 2, 2019

This PR requires #2648.

Fixes #2699. Fixes #2700.

Changelog Entry

Samples

Description

Add a new sample for composing Web Chat UI into a Smart Display.

This sample will be later updated to use Direct Line Speech channel.

image

Specific Changes

  • Moved WebSpeechPonyfill patching code from <BasicTranscript> to <Composer>

    • Components using Web Chat without our default UI, will continue to get the patched WebSpeechPonyfill.
    • The patch is to coalesces null ponyfill, into a naive/bypass ponyfill.
  • Moved <SayComposer> from <BasicTranscript> to <Composer>

    • Components using Web Chat without our default UI, will be able to use <SpeakActivity>.
  • Adopted the following packages because they do not provide ES5 builds. License will be keep in the source code.

  • When running under a browser without Web Audio API support (e.g. IE11), will disable speech recognition and synthesis in Direct Line Speech and give warnings.

  • Added new sample for Direct Line Speech with ES5.

  • Added new Smart Display sample.


  • Testing Added
    • Will do manual tests
  • Bump Speech SDK to official 1.8.1 on NPM
  • README.md for 01.d

@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage decreased (-2.7%) to 60.848% when pulling c6f9714 on compulim:sample-smart-display2 into 5b2e0c2 on microsoft:master.

CHANGELOG.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/src/index.css Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
samples/24.customization-smart-display/README.md Outdated Show resolved Hide resolved
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim changed the title Add Smart Display sample [Draft] Add Smart Display sample Dec 6, 2019
scripts/deploy_pages Outdated Show resolved Hide resolved
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending comments :)

@compulim compulim merged commit 10d9577 into microsoft:master Dec 10, 2019
@compulim compulim deleted the sample-smart-display2 branch December 10, 2019 07:47
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<SayComposer> and Adaptive Cards are not working when recomposing UI [DLS] Bundle not working in IE11
3 participants