-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smart Display sample #2649
Merged
Merged
Add Smart Display sample #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
December 2, 2019 14:40
corinagum
suggested changes
Dec 2, 2019
compulim
force-pushed
the
sample-smart-display2
branch
from
December 6, 2019 11:27
c6f9714
to
88d77fe
Compare
corinagum
reviewed
Dec 6, 2019
compulim
commented
Dec 6, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
reviewed
Dec 10, 2019
corinagum
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending comments :)
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
…otFramework-WebChat into sample-smart-display2
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Samples
Description
Add a new sample for composing Web Chat UI into a Smart Display.
This sample will be later updated to use Direct Line Speech channel.
Specific Changes
Moved
WebSpeechPonyfill
patching code from<BasicTranscript>
to<Composer>
WebSpeechPonyfill
.Moved
<SayComposer>
from<BasicTranscript>
to<Composer>
<SpeakActivity>
.Adopted the following packages because they do not provide ES5 builds. License will be keep in the source code.
abort-controller@3.0.0
p-defer@3.0.0
When running under a browser without Web Audio API support (e.g. IE11), will disable speech recognition and synthesis in Direct Line Speech and give warnings.
Added new sample for Direct Line Speech with ES5.
Added new Smart Display sample.
README.md
for01.d