Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React Hooks for customization (part 14) #2652

Merged
merged 10 commits into from
Dec 27, 2019
Merged

Add React Hooks for customization (part 14) #2652

merged 10 commits into from
Dec 27, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 2, 2019 •
edited
Loading

Related to #2539.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim, in the following PRs:
    • PR #2652: Update samples to use hooks

Description

This work will modify samples.

  • We will move some sample to functional components
  • We will use hooks instead of HOC
  • We will remove glamor from our samples to reduce emissions.

Specific Changes

  • 08.customziation-user-highlighting: Remove glamor
  • 09.customization-reaction-button: Move to functional component, using Web Chat hooks, remove glamor
  • 10.b.customization-password-input: Move to functional component, using Web Chat hooks, remove glamor
  • Remove 22.change-locale which is a draft of 22.customization-change-locale
  • Testing Added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.679% when pulling b1f436d on compulim:feat-redux-hooks-14 into 95ab4e6 on microsoft:master.

@corinagum corinagum added the R8 label Dec 3, 2019
@corinagum corinagum added the QOL label Dec 17, 2019
compulim and others added 3 commits December 27, 2019 13:28
@compulim @corinagum
Apply suggestions from code review
ad6ce71 
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim @corinagum
Update samples/09.customization-reaction-buttons/index.html
9c04c97 
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim
Rename to twoFACode
5f91fd9
@compulim compulim merged commit 31c2006 into microsoft:master Dec 27, 2019
@compulim compulim deleted the feat-redux-hooks-14 branch December 27, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

Assignees

@compulim compulim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks
3 participants
@compulim @coveralls @corinagum