Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ES5 versions of non-ES5 bundles #2774

Merged
merged 2 commits into from
Dec 27, 2019
Merged

Use ES5 versions of non-ES5 bundles #2774

merged 2 commits into from
Dec 27, 2019

Conversation

compulim
Copy link
Contributor

Fixes #2773.

Changelog Entry

Fixes

Description

Use ES5-pre-transpiled version of packages that did not offer ES5 modules.

Specific Changes

  • component: Use event-target-shim-es5
  • directlinespeech-sdk: Use abort-controller-es5, event-target-shim-es5 and p-defer-es5
  • Testing Added
    • Existing tests should cover the change

@coveralls
Copy link

Coverage Status

Coverage increased (+4.8%) to 65.915% when pulling df4741e on compulim:feat-es5 into 6c664a9 on microsoft:master.

tdurnford
tdurnford approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light

@compulim compulim merged commit 99b6892 into microsoft:master Dec 27, 2019
@compulim compulim deleted the feat-es5 branch December 27, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ES5 version of non-ES5 modules
3 participants
@compulim @coveralls @tdurnford