Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing typing indicator #2912

Merged
merged 17 commits into from
Feb 20, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 17, 2020

Fixes #2213.

Changelog Entry

Breaking changes

  • Customizable typing indicator: data and hook related to typing indicator are being revamped in PR #2912
    • lastTypingAt reducer is deprecated, use typing instead. The newer reducer contains typing indicator from the user
    • useLastTypingAt() hook is deprecated, use useActiveTyping(duration?: number) instead. For all typing information, pass Infinity to duration argument

Added

Samples

Description

This work will enable developers to customize the typing indicator. Also allow the developers to show the typing indicator for the user, in additional to the bot.

Specific Changes

  • API and data
    • Added new useActiveTyping hook
      • For listing participants (bot + user) who are actively typing
      • Optionally, developer can pass the timeout for inactivity
    • Added new typing reducer
    • Deprecated typingAt reducer and useLastTypingAt hook
    • Added useRenderTypingIndicator hook
  • UI
    • <BasicWebChat>: Added typingIndicatorMiddleware prop
    • <Composer>: Added typingIndicatorRenderer prop
  • Sample
    • Added a new sample
      • Override typing indicator to show typing activity from the user side, as well as from the bot side

To-do


  • Testing Added

@compulim compulim changed the title [DRAFT] Customizing typing indicator Customizing typing indicator Feb 17, 2020
@compulim compulim marked this pull request as ready for review February 17, 2020 07:52
@tdurnford tdurnford self-assigned this Feb 18, 2020
docs/HOOKS.md Outdated Show resolved Hide resolved
docs/HOOKS.md Outdated Show resolved Hide resolved
docs/HOOKS.md Outdated Show resolved Hide resolved
docs/HOOKS.md Outdated Show resolved Hide resolved
docs/HOOKS.md Outdated Show resolved Hide resolved
compulim and others added 2 commits February 21, 2020 04:38
Co-Authored-By: TJ Durnford <tjdford@gmail.com>
@compulim compulim merged commit 2172870 into microsoft:master Feb 20, 2020
@compulim compulim mentioned this pull request Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IC3] Customizing bot's typing indicator
3 participants