-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizing typing indicator #2912
Merged
compulim
merged 17 commits into
microsoft:master
from
compulim:feat-custom-typing-indicator
Feb 20, 2020
Merged
Customizing typing indicator #2912
compulim
merged 17 commits into
microsoft:master
from
compulim:feat-custom-typing-indicator
Feb 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
[DRAFT] Customizing typing indicator
Customizing typing indicator
Feb 17, 2020
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
February 17, 2020 07:52
compulim
force-pushed
the
feat-custom-typing-indicator
branch
from
February 19, 2020 22:29
f62adb5
to
c6e5bc0
Compare
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
reviewed
Feb 19, 2020
tdurnford
approved these changes
Feb 19, 2020
Co-Authored-By: TJ Durnford <tjdford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
lastTypingAt
reducer is deprecated, usetyping
instead. The newer reducer contains typing indicator from the useruseLastTypingAt()
hook is deprecated, useuseActiveTyping(duration?: number)
instead. For all typing information, passInfinity
toduration
argumentAdded
Samples
Description
This work will enable developers to customize the typing indicator. Also allow the developers to show the typing indicator for the user, in additional to the bot.
Specific Changes
useActiveTyping
hooktyping
reducertypingAt
reducer anduseLastTypingAt
hookuseRenderTypingIndicator
hook<BasicWebChat>
: AddedtypingIndicatorMiddleware
prop<Composer>
: AddedtypingIndicatorRenderer
propTo-do