-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry API and initial set of events #2922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
reviewed
Feb 20, 2020
Closed
corinagum
reviewed
Feb 20, 2020
corinagum
reviewed
Feb 20, 2020
corinagum
reviewed
Feb 20, 2020
corinagum
reviewed
Feb 20, 2020
corinagum
reviewed
Feb 20, 2020
corinagum
reviewed
Feb 20, 2020
corinagum
reviewed
Feb 20, 2020
compulim
force-pushed
the
feat-telemetry
branch
from
February 21, 2020 23:19
85e0d30
to
386aea1
Compare
compulim
changed the title
[DRAFT] Add telemetry API and initial set of events
Add telemetry API and initial set of events
Feb 22, 2020
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
February 22, 2020 10:17
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
corinagum
reviewed
Feb 24, 2020
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
compulim
force-pushed
the
feat-telemetry
branch
from
February 25, 2020 04:45
b7aa60f
to
b501c82
Compare
tdurnford
reviewed
Feb 25, 2020
tdurnford
reviewed
Feb 25, 2020
tdurnford
reviewed
Feb 25, 2020
tdurnford
reviewed
Feb 25, 2020
tdurnford
reviewed
Feb 25, 2020
tdurnford
reviewed
Feb 25, 2020
tdurnford
approved these changes
Feb 25, 2020
Co-Authored-By: TJ Durnford <tjdford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
This is an initial work, which will enable us to add more metrics sooner.
Although we emit metrics, we do not collect them and there is no default telemetry collector, a.k.a. it just go to void.
While this feature is optional, developers who are interested in our telemetry data will need to write code to integrate our telemetry collection API with service of their choice. If developers decided to collect any data, they should also provide privacy policy to their end-user.
We support 3 types of metrics: event, exception, and timing.
Specific Changes
useTelemetryDimension
,useTelemetryEvent
,useTelemetryException
, anduseTelemetryTiming
prop:locale
,prop:speechRecognition
,prop:speechSynthesis
,capability:downscaleImage:workerType
init
,sendFiles
,submitSendBox
sendFiles:makeThumbnail
To-do
<ErrorBoundary>
for fatal error