Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix observeOnce #2993

Merged
merged 3 commits into from
Mar 14, 2020
Merged

Fix observeOnce #2993

merged 3 commits into from
Mar 14, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 7, 2020 •
edited
Loading

Fixes #2989.

Changelog Entry

Fixed

Description

observeOnce was using an older signature which is only used in RxJS but not ES Observable. This cause tests in DirectLineSpeech to fail.

Specific Changes

  • Update observeOnce to use the newer call signature
  • Testing Added
    • Updated tests

@corinagum
Copy link
Contributor

Looks like this one has some failing tests

@compulim compulim merged commit c2fcb6b into microsoft:master Mar 14, 2020
@compulim compulim deleted the fix-2989 branch March 14, 2020 06:40
@compulim compulim mentioned this pull request May 15, 2020
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

observeOnce should use ES Observable call pattern
3 participants
@compulim @corinagum @tdurnford