Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usability on accessibility #3076

Merged
merged 8 commits into from
Apr 3, 2020
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 3, 2020

Fix #3075.

Changelog Entry

Fixed

  • Fixes #3075. Fix usability issues around accessibility, by @compulim in PR #3076
    • Fix timestamp should not be narrated more than once.
    • Associate the activity text with its attachments, by adding a role="region" to the activity DOM element.

Description

(See changelog above)

This may be a temporary fix until we found a better DOM structure.

Specific Changes

  • Update <StackLayout> to narrate as aria-label on the activity root DOM element
  • Update <CarouselFilmstrip> to match <StackLayout> on screen reader text
  • Update aria-relevant for <BasicTranscript> to only narrate additions of node
  • Remove <Timestamp> from narration, because it will be narrated by the activity

Test

  1. Run Windows Narrator (Windows + CTRL + ENTER)
  2. Say "hello" to the bot
    • Expect: The narration should be minimal and not repetitive
  3. Say "card inputs breakfast"
  4. Use mouse to focus on any box of "inputs card"
  5. Use mouse to focus on the button on "breakfast card"
    • Expect: The narration should mention it's on breakfast card
  6. Use mouse to focus on the dropbox of "breakfast card"
    • Expect: The narration should not mention it's on breakfast card again
  7. Use mouse to focus on any input on "card inputs"
    • Expect: The narration should mention it's on inputs card

  • Testing Added
    • No tests added because accessibility cannot be automated

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; See nit

@compulim compulim merged commit 7cadd02 into microsoft:master Apr 3, 2020
@compulim compulim deleted the exp-a11y-humana branch April 3, 2020 22:27
compulim added a commit that referenced this pull request Apr 7, 2020
* Experiment

* Clean up

* Clean up

* Add entry

* Fix ESLint

* Sorting

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
compulim added a commit that referenced this pull request Apr 7, 2020
* Experiment

* Clean up

* Clean up

* Add entry

* Fix ESLint

* Sorting

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: screen reader repeat timestamp multiple times
2 participants