Jocupi/external link indication #3108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeCupiV
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
|
ericmaino
suggested changes
Apr 17, 2020
| @@ -7,7 +7,7 @@ import sanitizeHTML from 'sanitize-html'; | |||
|
|
|||
| const SANITIZE_HTML_OPTIONS = { | |||
| allowedAttributes: { | |||
| a: ['aria-label', 'href', 'name', 'target', 'title'], | |||
| a: ['aria-label', 'href', 'name', 'target', 'title', 'role', 'class'], | |||
There was a problem hiding this comment.
I don't think that 'class' belongs in this list. As my understanding is that these are supported markdown attributes and we don't want the markdown author to support overriding this behavior.
It also looks like role was added as part of this change, but not necessarily used. It might be left over from another change you inherited.
| } | ||
|
|
||
| const urlAttrIndex = tokens[index].attrIndex('href'); | ||
| if (isExternal(urlAttrIndex)) { |
There was a problem hiding this comment.
These should be conditionally added since the markdown author could supply their own title
added 2 commits
April 17, 2020 14:43
…ternal or external links
…fice UI Fabric icons
|
Is there an update for this PR? There are a number of tree changes to Web Chat incoming, so my recommendation is to close this PR and open a new one. Please be sure to address compulim's comments above before filing the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3087
Description
Specific Changes