-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move focus to transcript after click on suggested actions #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
force-pushed
the
fix-2850-usefocus
branch
from
April 23, 2020 23:09
b17a75a
to
13e1b41
Compare
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
April 24, 2020 06:47
compulim
changed the title
[DRAFT] Move focus to transcript after click on suggested actions
Move focus to transcript after click on suggested actions
Apr 24, 2020
cwhitten
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
useFocus
hook and deprecatinguseFocusSendBox
hook, by @compulim in PR #3123setFocus
argument ofuseTextBoxSubmit
to supportmain
andsendBoxWithoutKeyboard
Fixed
Description
Enable focus on send box without virtual keyboard. And clean up on all focus management.
Specific Changes
useFocus('main' | 'sendBox' | 'sendBoxWithoutKeyboard')
useFocusSendBox
, which will becomeuseFocus('sendBox')