Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move focus to transcript after click on suggested actions #3123

Merged
merged 18 commits into from
Apr 28, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 22, 2020

Fixes #2850.

Changelog Entry

Added

  • Resolves #2850. Added new useFocus hook and deprecating useFocusSendBox hook, by @compulim in PR #3123
    • Modify setFocus argument of useTextBoxSubmit to support main and sendBoxWithoutKeyboard

Fixed

  • Fixes #2850. After click suggested action, should focus to send box without keyboard, by @compulim in PR #3123

Description

Enable focus on send box without virtual keyboard. And clean up on all focus management.

Specific Changes

  • Add new hook useFocus('main' | 'sendBox' | 'sendBoxWithoutKeyboard')
  • Deprecate useFocusSendBox, which will become useFocus('sendBox')
  • Focus management
    • Focus to main
      • After clicking on scroll to end button
    • Focus to send box (without keyboard)
      • After submitting text box
      • After clicking on "retry" of send status
      • After clicking on suggested action

  • Testing Added

@compulim compulim marked this pull request as ready for review April 24, 2020 06:47
@compulim compulim changed the title [DRAFT] Move focus to transcript after click on suggested actions Move focus to transcript after click on suggested actions Apr 24, 2020
@cwhitten cwhitten merged commit df4fb97 into microsoft:master Apr 28, 2020
@compulim compulim mentioned this pull request May 15, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants