Fix narration of "New messages" button #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
force-pushed
the
fix-3203-new-messages-button
branch
from
ac6b237
to
95c885b
Compare
tdurnford
reviewed
Jun 4, 2020
tdurnford
reviewed
Jun 4, 2020
tdurnford
reviewed
Jun 4, 2020
tdurnford
approved these changes
Jun 4, 2020
corinagum
reviewed
Jun 4, 2020
corinagum
approved these changes
Jun 4, 2020
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
When focusing on the "New messages" button, assistive technology are not reading its content. This is because the container of the button has a special flag "presentational children".
We need to build the button on the container instead.
Specific Changes
docs/ACCESSIBILITY.md<ScrollToEndButton>from<button>into<li>role="separator"will becomerole="presentation", we will use the default role (listitem) isnteadTesting Added