-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Target 4.10.1] Support Content Security Policy #3443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
August 31, 2020 22:17
compulim
changed the title
[DRAFT] Support Content Security Policy
Support Content Security Policy
Sep 1, 2020
compulim
changed the title
Support Content Security Policy
[DRAFT] Support Content Security Policy
Sep 1, 2020
compulim
changed the title
[DRAFT] Support Content Security Policy
Support Content Security Policy
Sep 1, 2020
corinagum
reviewed
Sep 2, 2020
corinagum
reviewed
Sep 2, 2020
corinagum
reviewed
Sep 3, 2020
compulim
changed the title
Support Content Security Policy
[Target 4.10.1] Support Content Security Policy
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending a couple comments
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
glamor
is being replaced bycreate-emotion
. The CSS hash and rule name is being prefixed withwebchat--css
with a random value.Changed
glamor@2.20.40
tocreate-emotion@10.0.27
blob:
scheme, instead ofdata:
schemewindow.MessagePort
andwindow.Worker
blob:
react-film@3.0.0
react-scroll-to-bottom@4.0.0
Samples
Description
This feature enables Web Chat to be embedded on a page with Content Security Policy enabled.
Design
Please refer to
CONTENT_SECURITY_POLICY.md
for design.Specific Changes
nonce
<style>
element, but not<img>
and other media tags (see/vote [Content Security Policy] Addnonce
support for<img>
and other tags #3445)glamor
tocreate-emotion
css-*
towebchat--css-xxxxx-*
blob:
scheme, instead ofdata:
schemeimg-src data:
is insecureblob:
window.Worker
react-film@3.0.0
react-scroll-to-bottom@4.0.0
useStyleToEmotionObject
to convert from object style toemotion
objectemotion
as part of our long-term dependency, this is also true forglamor
and most of our dependenciesuseNonce
fornonce
propCHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed