Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bot initials being undefined in AT text #3524

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix bot initials being undefined in AT text #3524

merged 1 commit into from
Oct 6, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 6, 2020 •
edited
Loading

Fixes #3489

Changelog Entry

Description

Specific Changes

Previously, bot initials were being said as undefined if initials have not been assigned.

  • Change already present for CarouselFilmStrip and StackedLayout
  • Therefore, only added for ScreenReaderActivity
  • NOTE: accessibility issue; currently no test framework

- [ ] I have added tests and executed them locally

  • I have updated CHANGELOG.md
    - [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum merged commit 175a3df into microsoft:master Oct 6, 2020
@compulim compulim mentioned this pull request Oct 29, 2020
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assistive technologies start reading Bot message with "Bot undefined said"
2 participants
@corinagum @tdurnford