Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API into new api package #3543

Merged
merged 21 commits into from
Oct 27, 2020
Merged

Refactor API into new api package #3543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0e42d55
Add API package
compulim Sep 29, 2020
3dbd54c
Continue refactoring
compulim Oct 5, 2020
e8d35d4
Continue refactoring
compulim Oct 5, 2020
7fa38cb
Fix tests
compulim Oct 6, 2020
322c348
Fix DLSpeech
compulim Oct 9, 2020
7c03f55
Fix speech support
compulim Oct 9, 2020
83c0167
Fix tests
compulim Oct 14, 2020
740d68e
Fix ESLint
compulim Oct 14, 2020
f5bf5e5
Fix tests
compulim Oct 15, 2020
f47d919
Fix ESLint
compulim Oct 15, 2020
20f4409
Fix all TODOs
compulim Oct 15, 2020
b9127af
Add back localize
compulim Oct 15, 2020
c301e36
Clean up
compulim Oct 15, 2020
ab145f9
Add entry
compulim Oct 15, 2020
bd57a2f
Apply suggestions from code review
compulim Oct 26, 2020
9948953
Apply PR suggestions
compulim Oct 26, 2020
438de16
Fix tests
compulim Oct 27, 2020
01fbc0e
Fix tests
compulim Oct 27, 2020
4dccb85
Fix tests
compulim Oct 27, 2020
d8838f4
Fix tests
compulim Oct 27, 2020
0ecfd60
Remove eslint-disable
compulim Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...js-accessibility-requirement-attachments-in-live-region-unknown-card-1-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 5 additions & 1 deletion packages/component/src/ErrorBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ const ErrorBox = ({ error, type }) => {
<ScreenReaderText text={localize('ACTIVITY_ERROR_BOX_TITLE')} />
<div className={errorBoxStyleSet}>
<div>{type}</div>
<pre>{error.stack}</pre>
{/* The callstack between production and development are different, thus, we should hide it for visual regression test */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{/* The callstack between production and development are different, thus, we should hide it for visual regression test */}
{/* The callstack between production and development are different; therefore we should hide it for visual regression tests */}

<details>
<summary>{error.message}</summary>
<pre>{error.stack}</pre>
</details>
</div>
</React.Fragment>
);
Expand Down