-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass userID prop to chat adapter setUserId() #3544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timenick
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
October 16, 2020 07:00
Adding [DRAFT] to this since there are DLJS changes & tests blocking. @timenick please remove [DRAFT] and ping us again when you're ready. |
corinagum
changed the title
Add user id support to webchat
[DRAFT] Add user id support to webchat
Oct 19, 2020
compulim
force-pushed
the
zhiwang/add-user-id-support
branch
from
February 10, 2021 01:32
4477a8b
to
15aad1f
Compare
compulim
changed the title
[DRAFT] Add user id support to webchat
Pass userID prop to chat adapter setUserId()
Feb 10, 2021
corinagum
reviewed
Feb 10, 2021
corinagum
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified the behavior with @p-nagpal and we agree it looks good. |
compulim
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Changed
botframework-directlinejs@0.14.1
Specific Changes
botframework-directlinejs@0.14.1
directLine.setUserId
if the function is available on the chat adapterNeed update the package.json and add tests after DLJS changes released.
Related to microsoft/BotFramework-DirectLineJS#316
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed