Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass userID prop to chat adapter setUserId() #3544

Merged
merged 12 commits into from
Feb 17, 2021

Conversation

timenick
Copy link
Contributor

@timenick timenick commented Oct 16, 2020

Fixes #2818

Changelog Entry

Added

Changed

Specific Changes

  • Bumped to botframework-directlinejs@0.14.1
  • Will now call directLine.setUserId if the function is available on the chat adapter
    • This will pass the user ID from Web Chat prop, to DLJS just before it connect
    • In scenarios, secret or token without user ID, developer can pass user ID thru props and the bot receiving the start conversation activity will receive the user ID

Need update the package.json and add tests after DLJS changes released.

Related to microsoft/BotFramework-DirectLineJS#316

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • ~Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • ~Browser and platform compatibilities reviewed
  • ~CSS styles reviewed (minimal rules, no z-index)
  • ~Documents reviewed (docs, samples, live demo)
  • ~Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • ~Security reviewed (no data URIs, check for nonce leak)
  • ~Tests reviewed (coverage, legitimacy)

@corinagum
Copy link
Contributor

Adding [DRAFT] to this since there are DLJS changes & tests blocking. @timenick please remove [DRAFT] and ping us again when you're ready.

@corinagum corinagum changed the title Add user id support to webchat [DRAFT] Add user id support to webchat Oct 19, 2020
@tdurnford tdurnford marked this pull request as draft October 19, 2020 18:30
@compulim compulim changed the title [DRAFT] Add user id support to webchat Pass userID prop to chat adapter setUserId() Feb 10, 2021
@compulim compulim marked this pull request as ready for review February 10, 2021 23:09
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim enabled auto-merge (squash) February 10, 2021 23:23
@compulim
Copy link
Contributor

Verified the behavior with @p-nagpal and we agree it looks good.

@compulim compulim merged commit ec6963d into master Feb 17, 2021
@compulim compulim deleted the zhiwang/add-user-id-support branch February 17, 2021 15:09
@compulim compulim restored the zhiwang/add-user-id-support branch February 17, 2021 15:09
@compulim compulim deleted the zhiwang/add-user-id-support branch February 17, 2021 15:09
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embed package] Pass userid to token generation logic
3 participants