Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility on Edge Chromium #3584

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 3, 2020

Fixes #3570.

Changelog Entry

Fixed

Description

Improves live region attachments labelling work in #3573 for Edge Chromium.

Tested on:

  • Microsoft Edge (Chromium) + Windows Narrator
  • Microsoft Edge (UWP) + Windows Narrator
  • Chrome on Windows + NVDA
  • Firefox on Windows + NVDA
  • macOS Safari + VoiceOver
  • iOS Safari + VoiceOver
  • Chrome on Android + TalkBack

Design

Today

<article>
  <div role="region">An image</div>
</article>

Tomorrow

<article aria-labelledby="a1b2c">
  <div id="a1b2c">An image</div>
</article>

Specific Changes

  • Modified all live region attachment middleware with the updated DOM tree
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side note: I think the attachment strings are a little clunky. Can we go over them sometime in R12?

@compulim compulim merged commit 5416516 into microsoft:master Nov 3, 2020
@compulim compulim deleted the fix-3570-2 branch November 3, 2020 23:12
@compulim compulim mentioned this pull request Nov 4, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AC: Not fully narrated in screen reader
2 participants