Center text on multiline send box #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
compulim
changed the title
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
force-pushed
the
fix-center-sendbox
branch
from
a376efd
to
448bf28
Compare
corinagum
reviewed
Jan 19, 2021
corinagum
reviewed
Jan 19, 2021
corinagum
reviewed
Jan 19, 2021
corinagum
approved these changes
Jan 19, 2021
corinagum
reviewed
Jan 19, 2021
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
compulim
force-pushed
the
fix-center-sendbox
branch
from
fb675cd
to
fa55d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
sendBoxButtonAlignmentfor button alignment in multi-line text mode, by @compulim in PR #3668Description
Currently, text and buttons was not aligned in multi-line text mode. This PR will vertically center text, and an additional option to align buttons to top/bottom or stretch. We default to stretch because it was the current behavior.
Design
We refactored the auto-resize text area out for clarity.
We copied the "mock Web Speech" component from older Web Driver tests to work in newer HTML tests.
Specific Changes
<BasicSendBox>to use<AutoResizeTextArea>__tests__/disabledUI.js<textarea>is disabledCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)z-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)