-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcript navigation by arrow keys #3703
Conversation
@amal-khalaf is planning on adding a new section on Technical limitations. I think that would be a good place to add documentation on why we did not add Ctrl + Alt + Arrow. Thoughts? |
TBH, I am unsure if ALT is a good modifier key. But I prefer to stick to only one combo, so IMO, single ALT looks better to me than ALT + CTRL. WhatsApp Web and Telegram use PGUP and PGDN and they are scrolling by ~80% of the page (i.e. |
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Changelog Entry
Added
Description
When focused in the transcript, pressing UP, DOWN, HOME, END should activate different activities (via
aria-activedescendant
).When focused in the send box, pressing PGUP, PGDN, HOME, END should scroll the transcript.
If "New messages" button appears, clicking on it should activate the next unread activity.
Design
(TBD)
Specific Changes
(TBD)
CHANGELOG.md
Review Checklist
CSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)