Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suggested action textwrap minheight behavior #3745

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Fix suggested action textwrap minheight behavior #3745

merged 4 commits into from
Feb 23, 2021

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Feb 22, 2021 •
edited
Loading

  • minHeight was not getting set if suggestedActionsStackedLayoutButtonMaxHeight was not a number. This is the fix.
  • IE11 also has weird behavior in suggested actions that is fixed if the suggested action (div) container has display: flex

@corinagum corinagum added this to the R12 milestone Feb 23, 2021
@corinagum corinagum merged commit a7cde7e into microsoft:master Feb 23, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@amal-khalaf amal-khalaf Awaiting requested review from amal-khalaf

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.
2 participants
@corinagum @compulim