-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adaptiveCardsParserMaxVersion style options #3778
Conversation
packages/bundle/src/adaptiveCards/hooks/internal/useParseAdaptiveCardJSON.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Patch draft: Note to CDN UsersUsers linking the CDN In 4.12.0, Web Chat bumped to version 2.5 of Adaptive Cards, which utilizes the 1.3 Adaptive Cards schema. Up until now, any Adaptive Cards in Web Chat using 1.3 schema properties (with card version <1.3), did not see any validation errors occur on their card (if applicable), due to these properties being ignored. With the 4.12.0 bump, any cards (even those marked as version < 1.3) using 1.3 properties will be validated and thrown by Web Chat if exceptions are detected. For example, the property How to fix - pre-4.12.1 patch
Note: The Adaptive Card builder has the 4.12.1 patch: New style property
|
Changelog Entry
Added
adaptiveCardsParserMaxVersion
style options for selecting the maximum supported version when parsing an Adaptive Cards, by @compulim in PR #3778Description
Adding a new
adaptiveCardsParserMaxVersion
to style options to select the "maximum version of schema to use when parsing Adaptive Cards".Design
As mentioned in #3777, this option will give developers more time before they can tweak their cards to render truthfully with the new Adaptive Cards 2.5.0 renderer, which support card schema up to 1.3.
Specific Changes
adaptiveCardsParserMaxVersion
style options to full and ES5 bundleCHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)