Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test harness and add browser pooling #3871

Merged
merged 169 commits into from
May 12, 2021
Merged
Show file tree
Hide file tree
Changes from 143 commits
Commits
Show all changes
169 commits
Select commit Hold shift + click to select a range
3ed5190
Update husky and lint-staged
compulim Apr 22, 2021
4019dbf
Add debug
compulim Apr 22, 2021
d3c7060
Only test transcript navigation tests
compulim Apr 22, 2021
75a15d9
Add message
compulim Apr 22, 2021
b4abdc7
Disable ESLint
compulim Apr 22, 2021
dd4e04a
Run transcript.navigation tests only
compulim Apr 22, 2021
4630ec1
Add more tests
compulim Apr 22, 2021
60268c1
Add messages
compulim Apr 22, 2021
efec1dc
Fix syntax error
compulim Apr 22, 2021
ae8c169
Update logic
compulim Apr 22, 2021
491f015
Add new message
compulim Apr 23, 2021
dbb0a18
Add message
compulim Apr 23, 2021
8837276
Update reporter
compulim Apr 23, 2021
8884d2a
Add message
compulim Apr 23, 2021
c9e42c6
Log even if error
compulim Apr 23, 2021
8e660dd
Clean up logs
compulim Apr 23, 2021
c601b0f
Update splice
compulim Apr 23, 2021
552d467
Fix scrollStabilized
compulim Apr 23, 2021
b11b15f
Fix timeout
compulim Apr 23, 2021
a6ae749
Add testharness2
compulim Apr 29, 2021
adb54a3
Move transcript.navigation.escapeKey
compulim Apr 30, 2021
b0db3a9
Move transcript.activityGrouping
compulim Apr 30, 2021
4d03153
Move transcript.activityGrouping
compulim Apr 30, 2021
568d33d
Clean up
compulim Apr 30, 2021
1a9e4f8
Move transcript.navigation.pageUpDown
compulim Apr 30, 2021
4526b46
Move transcript.navigation.adaptiveCard.focusInput
compulim Apr 30, 2021
2edf23e
Move transcript.navigation.*
compulim Apr 30, 2021
bbb166e
Move some accessibility tests
compulim Apr 30, 2021
94b36de
Move more accessibility tests
compulim Apr 30, 2021
8818d3d
Move all accessibility tests
compulim Apr 30, 2021
d30074e
Move all activities.* tests
compulim Apr 30, 2021
bbb9893
Move activityGrouping.* tests
compulim Apr 30, 2021
3d0e37a
Move adaptiveCards.* and autoScroll.*
compulim Apr 30, 2021
ba55f94
Move avatar.* tests
compulim Apr 30, 2021
73e19ca
Move cardAction.* tests
compulim May 1, 2021
c8a18c2
Move carousel.* tests
compulim May 1, 2021
a67b0d6
Move chatAdapter.* tests
compulim May 1, 2021
1120810
Move conversationStartProperties.* tests
compulim May 1, 2021
7f21867
Move deprecated.* and directLine.* tests
compulim May 1, 2021
9bc88dd
Move all focusManagement.* tests
compulim May 1, 2021
51450c9
Move heroCard.* tests
compulim May 1, 2021
d10a293
Move hooks.* tests
compulim May 1, 2021
0b51740
Move locale.* and markdown.* tests
compulim May 1, 2021
e6d4e1a
Move middleware.* tests
compulim May 1, 2021
c946f29
Move newMessageButton.* tests
compulim May 1, 2021
98cdd91
Move offlineUI.* tests
compulim May 1, 2021
254e870
Move replyToId.* tests
compulim May 1, 2021
f5a5d26
Move sendBox.* tests
compulim May 1, 2021
f226bc3
Move sendFiles.* tests
compulim May 1, 2021
6b8a820
Move speechRecognition.* tests
compulim May 1, 2021
1925506
Move styleOptions.* tests
compulim May 1, 2021
5573a24
Move suggestedActions.* tests
compulim May 1, 2021
6555259
Move timestamp.* tests
compulim May 1, 2021
e108ca2
Move toast.* tests
compulim May 1, 2021
a30d96b
Move transcript.* tests
compulim May 1, 2021
96cc923
Move use*.* tests
compulim May 1, 2021
b44ae16
Fix tests
compulim May 1, 2021
22c4122
Fix tests
compulim May 1, 2021
596adf4
Fix tests
compulim May 1, 2021
9a755ec
Fix tests
compulim May 1, 2021
5ed36f4
Fix tests
compulim May 1, 2021
52ce590
Fix tests
compulim May 1, 2021
085cd5d
Fix tests
compulim May 1, 2021
2996244
Fix tests
compulim May 1, 2021
da9402d
Fix Docker script
compulim May 1, 2021
55f5a75
Improve toolchain
compulim May 1, 2021
d12a245
Default to no-watch
compulim May 1, 2021
0a6fc11
Fix tests
compulim May 1, 2021
b8ae8ce
Fix tests
compulim May 1, 2021
d54bdae
Fix tests
compulim May 1, 2021
34952f7
Fix tests and clean up
compulim May 2, 2021
99de925
Fix build
compulim May 2, 2021
0922a9f
Add WD pool for Jest
compulim May 2, 2021
30b2dc5
Update housekeeping
compulim May 3, 2021
843c50d
Clean up
compulim May 3, 2021
0ae8f36
Add jestserver
compulim May 3, 2021
4390616
Update housekeep
compulim May 3, 2021
2d9a4cf
Touchup
compulim May 3, 2021
5850eb3
Consistent window size
compulim May 3, 2021
7d5a77d
Gracefully shutdown Jest server
compulim May 3, 2021
1bb60f5
Gracefully shutdown Jest server
compulim May 3, 2021
0d6d594
Clean up
compulim May 3, 2021
2eefaf3
Clean up instance after release
compulim May 3, 2021
673b560
Ignore get logs error
compulim May 3, 2021
fef6f6c
Clean up
compulim May 3, 2021
9950931
Housekeep asynchronously
compulim May 3, 2021
974ecb8
Rename
compulim May 3, 2021
2101aa2
Dump logs before quit
compulim May 3, 2021
3c9fdc5
Use global-agent
compulim May 3, 2021
cb67189
Improve test reliability
compulim May 4, 2021
c59f23b
Take fullscreen shot
compulim May 4, 2021
92191d1
Move session preparation code
compulim May 4, 2021
1df9007
Fix attachment
compulim May 4, 2021
5e4302c
Improve error stack
compulim May 4, 2021
8c93b22
Speed up
compulim May 4, 2021
bdb2186
Fix test
compulim May 4, 2021
45c3bf8
Fix test
compulim May 4, 2021
1be0618
Prepare session on reuse
compulim May 4, 2021
6c3a200
Update snapshot
compulim May 4, 2021
3f0929b
More __operation__
compulim May 4, 2021
d6291e9
Fix code coverage
compulim May 4, 2021
c367046
Increase shm_size
compulim May 4, 2021
3d0241f
Converge
compulim May 4, 2021
3e044a5
Fix tests
compulim May 4, 2021
46e8a90
Use stabilized
compulim May 4, 2021
60992d1
Use stabilized
compulim May 4, 2021
a3f5372
Wait for focus
compulim May 4, 2021
0229aeb
Remove one screenshot
compulim May 4, 2021
dbf62c5
Rename folders
compulim May 4, 2021
da516ee
Build test harness
compulim May 4, 2021
b44bb59
Clean up test harness
compulim May 4, 2021
767105b
Renames
compulim May 4, 2021
f32b6cb
Clean up
compulim May 4, 2021
e9d2955
Fix build
compulim May 4, 2021
fab7672
Fix test
compulim May 4, 2021
51bc11c
Remove unneeded plugin
compulim May 4, 2021
67f345e
Fix test
compulim May 4, 2021
c370929
Fix tests
compulim May 4, 2021
e2e6806
Fix tests
compulim May 4, 2021
c318e18
Fix tests
compulim May 4, 2021
1489e42
Fix test
compulim May 4, 2021
49222dd
Add comments
compulim May 4, 2021
9b299c2
Add entry
compulim May 4, 2021
bb7d161
Add eslint
compulim May 5, 2021
920fb77
Enable eslint
compulim May 5, 2021
0df9f51
Fix ESLint
compulim May 5, 2021
62b247d
Fix ESLint
compulim May 5, 2021
76b53b9
Update husky
compulim May 5, 2021
8e7f071
Update lint-staged
compulim May 5, 2021
4956efe
Update precommit
compulim May 5, 2021
51212ca
Update precommit
compulim May 5, 2021
44aed98
Update comment
compulim May 5, 2021
02cbe35
Remove unnecessary line
compulim May 5, 2021
d3165ef
Screenshot after fail
compulim May 5, 2021
1e08bb0
Wait for image load before snapshot
compulim May 5, 2021
69f657a
Wait for activity to be focused
compulim May 5, 2021
a0b92c3
Attach last screenshot
compulim May 5, 2021
a6dc98a
Wait for activities
compulim May 5, 2021
61eb678
Wait for capacity
compulim May 5, 2021
25f80ad
Add screenshot location
compulim May 5, 2021
eee6bd4
Fix error message
compulim May 5, 2021
5e7eb72
Fix filename
compulim May 5, 2021
c23a459
Add entry
compulim May 5, 2021
a86520a
Clean up
compulim May 5, 2021
e498903
Fix tests
compulim May 5, 2021
163dcbf
Add comment
compulim May 5, 2021
a9142b7
Clean up
compulim May 5, 2021
9076436
Clean up
compulim May 5, 2021
8360a55
Fix test reliability
compulim May 6, 2021
04f478c
Add tolerance
compulim May 6, 2021
9ad6300
Update entry
compulim May 6, 2021
b99dd03
Improve test reliability
compulim May 6, 2021
3d8cbb7
Remove loop
compulim May 6, 2021
51f9671
Update entry
compulim May 6, 2021
ec954a5
Improve test reliability
compulim May 6, 2021
5bd2c3b
Add all attachments
compulim May 7, 2021
dfcf755
Apply PR suggestions
compulim May 10, 2021
7310b0f
Apply suggestions from code review
compulim May 10, 2021
0b1fe65
Add comment
compulim May 10, 2021
8a7198d
Namespacing accessibility.delayActivity
compulim May 10, 2021
9621db5
Merge branch 'qol-r14-2' of https://github.com/microsoft/botframework…
compulim May 10, 2021
b545b3a
Update tofu
compulim May 10, 2021
12ba42a
Fix test
compulim May 11, 2021
ce35ef0
Fix test
compulim May 11, 2021
5d0127b
Fix test
compulim May 11, 2021
29f1a10
Test reliability
compulim May 11, 2021
fb84d49
Apply PR suggestions
compulim May 12, 2021
07d9bce
Remove unneeded marshal
compulim May 12, 2021
8c90de9
Update message
compulim May 12, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
/__tests__/__image_snapshots__
!/packages/bundle/dist
!/packages/playground/build
!/packages/testharness/dist
!/packages/test/harness/dist
!/packages/test/page-object/dist
!/serve-test.json
1 change: 1 addition & 0 deletions .husky/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pre-commit eol=lf
corinagum marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions .husky/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_
corinagum marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run lint-staged
4 changes: 2 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"files.exclude": {
"packages/*/dist": true,
"packages/*/lib": true
"packages/*/dist": false,
"packages/*/lib": false
},
"typescript.tsdk": "packages\\component\\node_modules\\typescript\\lib"
}
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [Unreleased]

### Added

- Cleanup repo URLs to point to main branch, by [@corinagum](https://github.com/corinagum), in PR [#3870](https://github.com/microsoft/BotFramework-WebChat/pull/3870)
- Improved test harness and added browser pooling, by [@compulim](https://github.com/compulim), in PR [#3871](https://github.com/microsoft/BotFramework-WebChat/pull/3871)
- Updated [`husky`](https://npmjs.com/package/husky), [`lint-staged`](https://npmjs.com/package/lint-staged) and corresponding `precommit` scripts, by [@compulim](https://github.com/compulim), in PR [#3871](https://github.com/microsoft/BotFramework-WebChat/pull/3871)

### Fixed

Expand Down
15 changes: 0 additions & 15 deletions Dockerfile-testharness

This file was deleted.

17 changes: 0 additions & 17 deletions Dockerfile-testharness2

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion __tests__/html/.gitignore

This file was deleted.

42 changes: 0 additions & 42 deletions __tests__/html/__jest__/WebChatEnvironment.js

This file was deleted.

110 changes: 0 additions & 110 deletions __tests__/html/__jest__/createJobObservable.js

This file was deleted.

22 changes: 0 additions & 22 deletions __tests__/html/__jest__/hostServe.js

This file was deleted.

8 changes: 0 additions & 8 deletions __tests__/html/__jest__/indent.js

This file was deleted.

15 changes: 0 additions & 15 deletions __tests__/html/__jest__/parseURLParams.js

This file was deleted.

122 changes: 0 additions & 122 deletions __tests__/html/__jest__/runPageProcessor.js

This file was deleted.

Loading