Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump microsoft-cognitiveservices-speech-sdk@1.17.0 #3907

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented May 21, 2021

Fixes #3693.

Changelog Entry

Changed

Description

Bump to microsoft-cognitiveservices-speech-sdk@1.17.0 and remove unnecessary code for previous versions.

Specific Changes

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review May 21, 2021 19:00
@compulim compulim merged commit 4598fa6 into main May 21, 2021
@compulim compulim deleted the bump-speech-sdk branch May 21, 2021 22:16
compulim added a commit that referenced this pull request Jun 22, 2021
* Bump microsoft-cognitiveservices-speech-sdk@1.17.0

* Update entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking] DLSpeech: fromHost set the endpoint URL incorrectly
2 participants