-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Adaptive Cards to 2.10.0 #4074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
October 15, 2021 00:08
This was referenced Oct 15, 2021
cwhitten
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .devcontainer directory needed for this change?
Not exactly for bumping AC 2.10 or accessibility. But I included it for even-simpler GitHub Codespaces experience, i.e. it will |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
role="heading"
to titles of rich card, by @compulim, in PR #4074Changed
@babel/runtime@7.15.4
adaptivecards@2.10.0
base64-arraybuffer@1.0.1
core-js@3.18.3
markdown-it-attrs-es5@2.0.1
react-film@3.1.0
react-say@2.1.0
react-scroll-to-bottom@4.2.0
@babel/cli@^7.15.7
@babel/core@^7.15.8
@babel/plugin-proposal-object-rest-spread@^7.15.6
@babel/plugin-transform-runtime@^7.15.8
@babel/preset-env@^7.15.8
@babel/preset-typescript@^7.15.0
@types/node@^16.10.9
@types/react@^17.0.29
@typescript-eslint/eslint-plugin@^4.33.0
@typescript-eslint/parser@^4.33.0
babel-jest@^27.2.5
concurrently@^6.3.0
core-js@^3.18.3
esbuild@^0.12.29
eslint-plugin-prettier@^3.4.1
eslint-plugin-react@^7.26.1
eslint@^7.32.0
istanbul-lib-coverage@^3.0.2
jest-environment-node@^27.2.5
jest@^27.2.5
node-fetch@^2.6.5
prettier@^2.4.1
restify@^8.6.0
selenium-webdriver@^4.0.0
serve@^12.0.1
strip-ansi@^6.0.1
terser-webpack-plugin@^5.2.4
webpack-cli@^4.9.0
webpack@^5.58.2
Description
Bumping to Adaptive Cards 2.10, which support schema 1.5.
A new
TextBlock.style
was added in AC schema 1.5 to support an accessibility feature: card title should haverole="heading"
.We are updating our rich card renderer on our side to support this feature and this is related to #4015.
Also, we are bumping all our dependencies.
Design
There should be no visual updates related to the
TextBlock.style = 'heading'
.However, AC 2.10 updated its layout a bit. We are updating our tests to follow their new style. The follow screenshot is from
__tests__/adaptiveCards.js
"container styles" test.After bump deps, all our peer deps should now support
react@17
(i.e.react >= 16.8.6
).Updated to
prettier@2.4
, they renamedjsxBracketSameLine
tobracketSameLine
, https://prettier.io/blog/2021/09/09/2.4.0.html.Specific Changes
adaptivecards@2.10.0
.prettierrc.yml
to usebracketSameLine
overjsxBracketSameLine
devcontainer.json
for GitHub CodespacesCHANGELOG.md
I have updated documentationReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)