Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Adaptive Cards to 2.10.0 #4074

Merged
merged 12 commits into from
Oct 15, 2021
Merged

Bump Adaptive Cards to 2.10.0 #4074

merged 12 commits into from
Oct 15, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 14, 2021

Related #4015. Fixed #4034.

Changelog Entry

Fixed

Changed

Description

Bumping to Adaptive Cards 2.10, which support schema 1.5.

A new TextBlock.style was added in AC schema 1.5 to support an accessibility feature: card title should have role="heading".

We are updating our rich card renderer on our side to support this feature and this is related to #4015.

Also, we are bumping all our dependencies.

Design

There should be no visual updates related to the TextBlock.style = 'heading'.

However, AC 2.10 updated its layout a bit. We are updating our tests to follow their new style. The follow screenshot is from __tests__/adaptiveCards.js "container styles" test.

adaptive-cards-js-container-styles-1-diff

After bump deps, all our peer deps should now support react@17 (i.e. react >= 16.8.6).

Updated to prettier@2.4, they renamed jsxBracketSameLine to bracketSameLine, https://prettier.io/blog/2021/09/09/2.4.0.html.

Specific Changes

  • Bump to adaptivecards@2.10.0
  • Bump dependencies to reduce vulnerability ranking
  • Updated all .prettierrc.yml to use bracketSameLine over jsxBracketSameLine
  • Added devcontainer.json for GitHub Codespaces
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .devcontainer directory needed for this change?

@compulim
Copy link
Contributor Author

Not exactly for bumping AC 2.10 or accessibility. But I included it for even-simpler GitHub Codespaces experience, i.e. it will npm install and build everything on boot.

@compulim compulim merged commit 53dfaa8 into microsoft:main Oct 15, 2021
@compulim compulim deleted the bump-deps-ac branch October 15, 2021 16:33
@compulim compulim mentioned this pull request Jan 26, 2022
11 tasks
@compulim compulim mentioned this pull request Mar 1, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants