-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sequence ID for sorting activities #4203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
force-pushed
the
feat-sequence-id
branch
from
March 14, 2022 02:05
81bb0ea
to
a08f932
Compare
compulim
commented
Mar 15, 2022
compulim
commented
Mar 15, 2022
packages/api/src/hooks/middleware/createDefaultGroupActivitiesMiddleware.ts
Show resolved
Hide resolved
compulim
commented
Mar 15, 2022
compulim
commented
Mar 15, 2022
packages/component/src/Middleware/GroupActivities/createCoreMiddleware.js
Show resolved
Hide resolved
compulim
commented
Mar 15, 2022
compulim
commented
Mar 15, 2022
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford,
tonyanziano and
beyackle
as code owners
March 15, 2022 11:45
cwhitten
previously approved these changes
Mar 15, 2022
compulim
force-pushed
the
feat-sequence-id
branch
from
March 25, 2022 22:12
5efe0a2
to
2c4b65c
Compare
cwhitten
previously approved these changes
Apr 7, 2022
tdurnford
previously approved these changes
Apr 7, 2022
tdurnford
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
activity.channelData['webchat:sequence-id']
and fallback to epoch time ofactivity.timestamp
, by @compulim, in PR #4203Description
Today, we use
activity.timestamp
for sorting activities.However, in ACS/Omnichannel, the server timestamp has a resolution too low for sorting (up to 1 second).
We are adding
activity.channelData['webchat:sequence-id']: number
and will use this integer value overactivity.timestamp
. If not provided, we will fallback to epoch ofactivity.timestamp
.Design
Please refer to the
SORTING.md
for design.Specific Changes
0.001
activities
reducer now use sequence ID for sort keysactivity.channelData.clientTimestamp
toactivity.localTimestamp
clientTimestamp
was used for "send failed, retry" prompts, usinglocalTimestamp
should have minimal impacttype WebChatActivity
type DirectLineActivity
but better defined to handlechannelData
and other Web Chat-specific data structuretype DirectLineActivity
will be used only for communicating with DirectLineJSimport type {}
andexport type {}
overimport {}
andexport default
for better tree-shakingCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)