Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation keys should work in Suggested Actions under IE Mode #4320

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jun 17, 2022

Fixes #4319.

Changelog Entry

Fixed

  • Fixes #4319. Fixed navigation keys not working in suggested actions under IE Mode, by @compulim, in PR #4320

Description

Under IE Mode, the keydown event will express LEFT arrow key as Left, instead of ArrowLeft. Same for other navigation keys.

Design

Specific Changes

  • Updated the handleKeyDown for <RovingTabIndex> to handle both ArrowLeft and Left equally, also for other navigation keys
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review June 17, 2022 15:24
@compulim compulim merged commit b0004fa into microsoft:main Jun 17, 2022
@compulim compulim deleted the fix-4319 branch June 17, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE Mode: Suggested actions cannot be navigated using left/right arrow keys
2 participants