Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Finance Digital Assistant_Profile_like_AI4W-Ensures buttons have discernible text (.webchat__suggested-action__button[aria-keyshortcuts="Alt\ \+\ Shift\ \+\ A"]) #4333

Closed
KattaBhargav opened this issue Jun 28, 2022 · 6 comments
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport exempt from daily DRI report

Comments

@KattaBhargav
Copy link

Environment Details:

  • Application Name: Finance Digital Assistant.
  • #URL: Finance Digital Assistant (microsoft.com)
  • OS Details:
    Microsoft Windows 11 Enterprise Version 21H2(OS build: 22000.318)
    Chromium Edge Version: Version 100.0.1185.44 (Official build) (64-bit)

Issue:

Ensures buttons have discernible text (button-name - https://accessibilityinsights.io/info-examples/web/button-name)

Target application:

Finance Digital Assistant - https://staging-fda.microsoft.com/fda/?&hostappid=1ED4BBD7-CF02-41D2-8363-8F21EF7F07F5

Element path:

.react-film__filmstrip__item:nth-child(1) > .webchat__suggested-action.webchat--css-ohhjn-xccdat.webchat--css-ohhjn-oe4onf > .webchat__suggested-action__button[aria-keyshortcuts="Alt\ +\ Shift\ +\ A"]

Snippet:

How to fix:

Fix any of the following:

  1. Element does not have inner text that is visible to screen readers
  2. aria-label attribute does not exist or is empty
  3. aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  4. Element has no title attribute
  5. Element's default semantics were not overridden with role="none" or role="presentation"

MAS Reference:

MAS 4.1.2 – Name, Role, Value

@KattaBhargav
Copy link
Author

#A11yMAS;#A11ySev2;#HCL;#WCAG4.1.2;#Accessibility;#Win11-Edge(Chromium);#BotFrameworkWebChat-Aug21;#Linked:Bug8884824;#LinkedBug;

@KattaBhargav
Copy link
Author

Bug copied from Azurebot team Bug id:-BUG 8884824

@compulim
Copy link
Contributor

compulim commented Jun 28, 2022

Thanks @KattaBhargav. This will take some time, my backlog of accessibility stuff is quite full right now. 😁

And I have access to the bot. 😉

@compulim
Copy link
Contributor

There are no repro steps in the issue. I am guessing this issue is talking about the upvote/downvote button that appears after a conversation.

image

@compulim
Copy link
Contributor

compulim commented Jul 25, 2022

There are two things need to be done to resolve this issue:

  1. Web Chat to support imageAltText field
  2. Bot author needs to use this field
    • Currently, the bot does not reply with imageAltText
    • image

@compulim compulim added this to the release-4.15.5 milestone Sep 30, 2022
@compulim compulim added the bug Indicates an unexpected problem or an unintended behavior. label Sep 30, 2022
@compulim
Copy link
Contributor

This is fixed on Web Chat side in microsoft/botframework-sdk#4441.

The bot author would still need to modify their bot to use this field. Instructions have been given above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport exempt from daily DRI report
Projects
None yet
Development

No branches or pull requests

3 participants